Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More tests/coverage and bug fixes #34

Merged
merged 1 commit into from
Jan 16, 2017
Merged

More tests/coverage and bug fixes #34

merged 1 commit into from
Jan 16, 2017

Conversation

tejashah88
Copy link
Member

  • Added tests for fail cases and schemas/utterances
  • Fixed bug while trying to retrieve schema/utterances with GET request
  • Updated messages that display an error to be displayed by self.error
  • Optimized some tests to not always start a new server instance after every test

@tejashah88
More tests/coverage and bug fixes
0ec22e4 
fixed wrong folder separations

hopefully travis CI doesn't complain about realpath problems

Fail examples should be expecting 404 error, NOT 200

fixed path problems with 'invalid_examples' folder

removed testing of failure detection when main file is not present
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0ec22e4 on tejashah88:master into ** on alexa-js:master**.

@dblock dblock merged commit fa1568b into alexa-js:master Jan 16, 2017
@dblock
Copy link
Collaborator

dblock commented Jan 16, 2017

Lot of thumbs up from me! Merged.

@dblock dblock mentioned this pull request Jan 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejashah88 @coveralls @dblock